今年年初vmware官方修复了该产品Thrift服务中的一个未授权rce漏洞，CVE编号CVE-2022-31704，通过对比补丁发现在http服务中也修复了两个漏洞，一个路径穿越漏洞和一个bypass csrf token漏洞。

漏洞分析

首先分析路径穿越漏洞：

可以看到这里接收到iconUrl参数后,调用了ContentPackUtil.getIconFileData方法处理。

这里没有做任何过滤就有读文件操作,读了文件之后做了一次base64编码。接下来发送http请求测试一下。

http响应包的icon数据base64解码后：

可以看到这里成功复现了路径穿越漏洞。

列一下调用栈：

getIconFileData:401, ContentPackUtil (com.vmware.loginsight.commons.contentpack)
exportContentPackFromJson:445, ContentPackActionBean (com.vmware.loginsight.web.actions.misc)
invoke0:-1, NativeMethodAccessorImpl (sun.reflect)
invoke:62, NativeMethodAccessorImpl (sun.reflect)
invoke:43, DelegatingMethodAccessorImpl (sun.reflect)
invoke:498, Method (java.lang.reflect)
intercept:456, DispatcherHelper$6 (net.sourceforge.stripes.controller)
proceed:158, ExecutionContext (net.sourceforge.stripes.controller)
interceptEventHandling:188, SecurityInterceptor (org.stripesstuff.plugin.security)
intercept:120, SecurityInterceptor (org.stripesstuff.plugin.security)
proceed:155, ExecutionContext (net.sourceforge.stripes.controller)
intercept:113, BeforeAfterMethodInterceptor (net.sourceforge.stripes.controller)
proceed:155, ExecutionContext (net.sourceforge.stripes.controller)
wrap:74, ExecutionContext (net.sourceforge.stripes.controller)
invokeEventHandler:454, DispatcherHelper (net.sourceforge.stripes.controller)
invokeEventHandler:278, DispatcherServlet (net.sourceforge.stripes.controller)
service:160, DispatcherServlet (net.sourceforge.stripes.controller)
service:764, HttpServlet (javax.servlet.http)
doFilter:453, DynamicMappingFilter$2 (net.sourceforge.stripes.controller)
doFilter:260, StripesFilter (net.sourceforge.stripes.controller)
doFilter:440, DynamicMappingFilter (net.sourceforge.stripes.controller)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:125, ResponseOverrideFilter (org.displaytag.filter)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:180, RestCsrfPreventionFilter (com.vmware.loginsight.web.stripesext)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:126, HttpHeaderSecurityFilter (org.apache.catalina.filters)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:40, CSPFilter (com.vmware.loginsight.web.stripesext)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:24, UTF8EncodingFilter (com.vmware.loginsight.web.utilities)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:29, ReferrerPolicyFilter (com.vmware.loginsight.web.utilities)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:30, CacheControlFilter (com.vmware.loginsight.web.utilities)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
doFilter:31, UrlRewriteFilter (com.vmware.loginsight.web.stripesext)
internalDoFilter:193, ApplicationFilterChain (org.apache.catalina.core)
doFilter:166, ApplicationFilterChain (org.apache.catalina.core)
invoke:196, StandardWrapperValve (org.apache.catalina.core)
invoke:97, StandardContextValve (org.apache.catalina.core)
invoke:661, AuthenticatorBase (org.apache.catalina.authenticator)
invoke:661, AuthenticatorBase (org.apache.catalina.authenticator)
invoke:135, StandardHostValve (org.apache.catalina.core)
invoke:81, ErrorReportValve (org.apache.catalina.valves)
invoke:81, ErrorReportValve (org.apache.catalina.valves)
invoke:698, AbstractAccessLogValve (org.apache.catalina.valves)
invoke:261, SingleSignOn (org.apache.catalina.authenticator)
invoke:769, RemoteIpValve (org.apache.catalina.valves)
invoke:78, StandardEngineValve (org.apache.catalina.core)
service:366, CoyoteAdapter (org.apache.catalina.connector)
service:639, Http11Processor (org.apache.coyote.http11)
process:65, AbstractProcessorLight (org.apache.coyote)
process:847, AbstractProtocol$ConnectionHandler (org.apache.coyote)
run:2168, AprEndpoint$SocketWithOptionsProcessor (org.apache.tomcat.util.net)
runWorker:1191, ThreadPoolExecutor (org.apache.tomcat.util.threads)
run:659, ThreadPoolExecutor$Worker (org.apache.tomcat.util.threads)
run:61, TaskThread$WrappingRunnable (org.apache.tomcat.util.threads)
run:748, Thread (java.lang)

再来分析一下bypass csrf token漏洞。

在上面的http request请求数据包中可以发现http header头中存在X-Csrf-Token字段,如果去掉该字段http响应包会返回403拒绝访问。

查看校验X-Csrf-Token字段代码。

可以看到代码里使用正则表达式去判断URI字符,这里构造特殊的URI尝试绕过这个校验。

这里发送的http请求数据包没有X-Csrf-Token字段,http响应包也返回了200。该服务权限校验还判断了session数据所以无法绕过权限,只能绕过X-Csrf-Token字段。

修复建议

请参考vmware官网修复文档
https://www.vmware.com/security/advisories/VMSA-2023-0001.html